compose: Use GVariantDict, not manual hash table
#3760
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
Skipping CI for Draft Pull Request. |
| rpmostree_context_get_rpmmd_repo_commit_metadata (self->corectx)); | ||
| g_variant_dict_insert_value ( | ||
| self->metadata, "rpmostree.rpmmd-repos", | ||
| rpmostree_context_get_rpmmd_repo_commit_metadata (self->corectx)); |
There was a problem hiding this comment.
Aren't we double referencing here?
There's a dedicated type for a mapping from "string to variant" in `GVariantDict`. Use it instead of rolling our own with `GHashTable`. The advantage here is improved ergonomics from the C side; e.g. we can directly pass C strings for values and have the variant allocated internally. But more importantly, this is prep for oxidizing things here because we can pass `GVariantDict` to/from Rust easily, not so with `GHashTable`.
cgwalters
force-pushed
the
compose-variantdict
branch
from
dbc756e
to
f89f5cd
Compare
Yeah, the CI failure is definitely related, but I don't yet understand it either. Not critical, will come back to this some point later. |
|
@cgwalters: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There's a dedicated type for a mapping from "string to variant" in
GVariantDict. Use it instead of rolling our own withGHashTable.The advantage here is improved ergonomics from the C side; e.g.
we can directly pass C strings for values and have the variant
allocated internally.
But more importantly, this is prep for oxidizing things here because
we can pass
GVariantDictto/from Rust easily, not so withGHashTable.