-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust the order of t:urlDecodeUni and t:utf8toUnicode in 941160 PL1 #3450
Conversation
Hi @Bxlxx. Thank for this PR. Can you, please, correctly set subject and description? |
changelog comment: feat: Adjusting the order of transformations in rule 941160 (bxlxx) |
This is a change that needs to be discussed with regards to other rules as well. Let's hold back until we have discussed this. |
Adding this to the agenda for meeting next Monday. |
BTW, no decision was taken in the March meeting. No one volunteered to take a more holistic look on the order of transformation yet. |
@dune73 From what I see in the original report, wouldn't this be the expected sequence for transformations? If this is fixing something, why don't we merge this one first and then create a new issue to track doing this for the rest? |
Here is my interpretation of what is happening: Old: utf8toUnicode,t:urlDecodeUni
New: t:urlDecodeUni,t:utf8toUnicode
If this interpretation is correct, then I do not see the PR as the desired behavior. |
Adjusting the order of
t:urlDecodeUni
andt:utf8toUnicode
transformations in rule941160
to prevent FPs.Fixes #3449.