Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix FP test to fail when condition not met #3702

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: fix FP test to fail when condition not met #3702

merged 2 commits into from
May 17, 2024

Conversation

theseion
Copy link
Contributor

@theseion theseion commented May 10, 2024 •
edited

Refs #3643

@theseion theseion requested a review from RedXanadu May 10, 2024 19:43
@theseion theseion added the release:ignore Ignore for changelog release label May 10, 2024
@azurit
Copy link
Member

azurit commented May 17, 2024

Why is this test modification needed?

@theseion
Copy link
Contributor Author

Because the original test doesn't fail without the FP fix.

@theseion theseion added this pull request to the merge queue May 17, 2024
Merged via the queue into coreruleset:main with commit 6a3df15 May 17, 2024
4 checks passed
@theseion theseion deleted the fix-fp-test branch May 17, 2024 14:57
@dune73 dune73 mentioned this pull request Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azurit azurit azurit approved these changes

@RedXanadu RedXanadu Awaiting requested review from RedXanadu

Assignees
No one assigned
Labels
release:ignore Ignore for changelog release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theseion @azurit