Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Facility link and unlink button for non-admin users #7738

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

Hide Clear Home Facility button:
image

Give Error notification for link and unlink buttons
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner April 29, 2024 15:02
Copy link

vercel bot commented Apr 29, 2024

@Pranshu1902 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e3c26f9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6643bc586635a5000827c19e
😎 Deploy Preview https://deploy-preview-7738--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 30, 2024
@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Apr 30, 2024
@nihal467
Copy link
Member

nihal467 commented May 7, 2024

@Pranshu1902

image

above is the current stage screenshot

image

above is the PR deployment

  • the PR is not showing the home facility page, can you check into this issue and reverify the code change you made while clearing the merge conflict

@Pranshu1902
Copy link
Contributor Author

@nihal467 resolved the conflicts
updated view:
image

@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@Pranshu1902
image

as per the issue, the button was suggested to be hidden, as non-admin users have no privilege to use it

Copy link

github-actions bot commented May 8, 2024

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 8, 2024
@Pranshu1902
Copy link
Contributor Author

@nihal467 Updated view:
image

@Pranshu1902 Pranshu1902 added needs testing and removed changes required merge conflict pull requests with merge conflict labels May 8, 2024
@nihal467
Copy link
Member

@Pranshu1902 blocking it for further clarification from @aparnacoronasafe

@nihal467
Copy link
Member

@Pranshu1902 can you modify the PR based on the latest expected behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor user privileges in linked facility functionality
2 participants