Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated discharged patients page #7744

Merged
merged 7 commits into from May 15, 2024
Merged

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Apr 30, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@skks1212 skks1212 requested a review from a team as a code owner April 30, 2024 12:39
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 6:43am

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 894ee22
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66445989745d3500080b822f
😎 Deploy Preview https://deploy-preview-7744--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 30, 2024

Passing run #2528 ↗︎

0 123 0 0 Flakiness 0

Details:

Updated discharged patients page
Project: CARE Commit: 894ee220f3
Status: Passed Duration: 02:56 💡
Started: May 15, 2024 6:48 AM Ended: May 15, 2024 6:51 AM

Review all test suite changes for PR #7744 ↗︎

@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@skks1212 makes the necessary changes request in the backend

Copy link

github-actions bot commented May 8, 2024

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 8, 2024
@nihal467
Copy link
Member

nihal467 commented May 14, 2024

@skks1212
image

can you fix the responsive issue ASAP

image

  • @skks1212 @aparnacoronasafe the geographic-based filtering is not relevant for a facility-specific discharge page, so kindly check which filters from the existing advanced filter are required in this discharge patient page

@aparnacoronasafe
Copy link
Member

Only remove the "Facility" and "Facility" type from the geographic filter. Keep the remaining as is.

@nihal467 @skks1212

@khavinshankar khavinshankar merged commit 245c811 into develop May 15, 2024
60 of 62 checks passed
@khavinshankar khavinshankar deleted the discharged-patients-page branch May 15, 2024 06:56
Copy link

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

nihal467 added a commit that referenced this pull request May 17, 2024
khavinshankar pushed a commit that referenced this pull request May 17, 2024
khavinshankar added a commit that referenced this pull request May 17, 2024
Revert "Updated discharged patients page (#7744)" (#7837) | Merge Develop to Staging v24.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants