Implement histogram iterators for batch #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
commented
May 13, 2024
| Timestamps [BatchSize]int64 | ||
| Values [BatchSize]float64 | ||
| Histograms [BatchSize]*histogram.Histogram | ||
| FloatHistograms [BatchSize]*histogram.FloatHistogram |
There was a problem hiding this comment.
Any idea how I can change to make Batch smaller? It should be only 1 value type per batch and other array are redundant.
alanprot
reviewed
May 14, 2024
Comment on lines
+84
to
+85
| // The batch reached it intended size or a new value type is used. | ||
| // Add another batch to the result and use it for further appending. |
There was a problem hiding this comment.
Is it possible to change the value type?
There was a problem hiding this comment.
Each batch will only have one value type.
alanprot
approved these changes
May 14, 2024
|
Amazing. LGTM |
|
Benchmark results on current implementation compared with the old code. Old version seems having much better CPU time probably since the logic is simpler. No need to check different chunk value types. It is hard to tell if CPU increase is relevant to the two additional arrays in batch type. Old version has better allocation, too, which is expected. Although the change is small. |
|
My plan is to combine the two histogram arrays into one and use unsafe pointer to store them together. I will implement that and run the benchmark again. |
|
Implemented the unsafe version. It is still worse than the version without support native histograms. But it is better than the version with two histogram arrays. I am going to switch to use the unsafe version. |
|
Discussed with @alanprot and we think it is better to use the original version without unsafe pointer. We can optimize this code when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support native histogram chunks in batch iterator. This should unlock native histogram support in Querier.
Since we haven't added support to ingest native histograms yet, I will try to add querying native histograms of Querier in another PR.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]