Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cortex_ingester_tsdb_head_samples_appended_total metric dimentions #5952

Merged
merged 2 commits into from
May 14, 2024

Conversation

alanprot
Copy link
Member

What this PR does:
We have the user and type dimensions in the wrong order for this metric. This PR is fixing that.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot requested a review from yeya24 May 14, 2024 22:32
Copy link
Collaborator

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yeya24 yeya24 enabled auto-merge May 14, 2024 23:05
@yeya24 yeya24 merged commit 2527f9e into cortexproject:master May 14, 2024
16 checks passed
@alanprot alanprot deleted the fix-samples_appended_total branch May 14, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants