fix: do not resolve stopDir when undefined

Fixed: #317
cosmiconfig · Sep 2, 2023 · 59082e2 · 59082e2
1 parent 6476b36
commit 59082e2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/src/Explorer.ts b/src/Explorer.ts
@@ -34,7 +34,7 @@ export class Explorer extends ExplorerBase<InternalOptions> {
       }
     }
 
-    const stopDir = path.resolve(this.config.stopDir);
+    const stopDir = this.config.stopDir && path.resolve(this.config.stopDir);
     from = path.resolve(from);
     const search = async (): Promise<CosmiconfigResult> => {
       /* istanbul ignore if -- @preserve */

diff --git a/src/ExplorerSync.ts b/src/ExplorerSync.ts
@@ -32,7 +32,7 @@ export class ExplorerSync extends ExplorerBase<InternalOptionsSync> {
       }
     }
 
-    const stopDir = path.resolve(this.config.stopDir);
+    const stopDir = this.config.stopDir && path.resolve(this.config.stopDir);
     from = path.resolve(from);
     const search = (): CosmiconfigResult => {
       /* istanbul ignore if -- @preserve */

diff --git a/test/successful-files.test.ts b/test/successful-files.test.ts
@@ -601,3 +601,15 @@ describe('[#313] config search does not fail if there is a file named .config',
     expect(result).toBeNull();
   });
 });
+
+describe('[#317] `explorer.search(...)` should not crashes with `{stopDir: undefined}` option', () => {
+  test('sync', () => {
+    const result = cosmiconfigSync('tester', { stopDir: undefined }).search();
+    expect(result).toBeNull();
+  });
+
+  test('async', async () => {
+    const result = await cosmiconfig('tester', { stopDir: undefined }).search();
+    expect(result).toBeNull();
+  });
+});