Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no loader error for unsupported extension #153

Merged
merged 1 commit into from
Aug 9, 2018
Merged

fix: no loader error for unsupported extension #153

merged 1 commit into from
Aug 9, 2018

Conversation

ikatyang
Copy link
Contributor

@ikatyang ikatyang commented Aug 9, 2018

Context: prettier/prettier#4962

Fixes Cannot read property 'sync' of undefined for unsupported extension.

@ikatyang ikatyang mentioned this pull request Aug 9, 2018
Closed
sudo-suhas
sudo-suhas approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtheclark
Copy link
Collaborator

Great fix, thanks. I'll cut a release soon.

@davidtheclark davidtheclark merged commit 5658ffc into cosmiconfig:master Aug 9, 2018
@ikatyang ikatyang deleted the fix/no-loader-error branch August 9, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @davidtheclark @sudo-suhas