Implement packageFilenames: specify which files get the package.json special treatment #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifies filenames that should get the package.json special treatment, where they're parsed as strict JSON and the packageProp is extracted.
|
Updated; tests are passing; coverage is 100%. |
|
I ended up using find-up in mocha, so my use-case for this feature doesn't exist anymore. I appreciate everyone taking the time to discuss. mochajs/mocha#3830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #172.
Adds a new option
packageFilenames: null | string | Array<string>;Defaults to['package.json']. Controls which config files will be given special treatment as apackage.jsonfile.If you want to pull config from a
packagePropof an alternative file, saymanifest.json, you can do that.You can also disable special-casing entirely, so that
package.jsoncan be loaded through the same code paths as any other config file.