Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new log lines and more info to some existing log lines #1335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

korayvt
Copy link
Contributor

@korayvt korayvt commented Dec 1, 2023

I needed these logs in my debug sessions. I think this will help others too.

@eakraly
Copy link
Collaborator

eakraly commented Dec 3, 2023

Hi @korayvt !
Thank you for your contribution!

Could you please extend your description with following information to make our job easier:

  • How did you change logging?
  • In what cases is it printed?
  • Examples of before and after
  • Is it an opt-in option? Is there any configuration?

Regarding last question - it is important we try to keep compatibility and at least try and document logging changes for version release

Thank you!

@korayvt
Copy link
Contributor Author

korayvt commented Dec 19, 2023

Hi @eakraly

Modified log line: Remote address is added to incoming packet log line.

INFO: session 002000000000000017: realm <turn.bip.com> user <1702970778:tyhlstw2adfs> remote:<1.17.28.40:46019>: incoming packet ALLOCATE processed, success
INFO: session 002000000000000017: realm <turn.bip.com> user <1702970778:tyhlstw2adfs> remote:<1.17.28.40:46019>: incoming packet REFRESH processed, success
INFO: session 002000000000000017: realm <turn.bip.com> user <1702970778:tyhlstw2adfs> remote:<1.17.28.40:46019>: incoming packet CREATE_PERMISSION processed, success

New Log Line: xor_relayed_addr and xor_mapped_addr are printed after turn allocation completed.
INFO: session 002000000000000017: handle_turn_allocate: xor_relayed_addr ip4=[88.18.1.91:42908] ip6=[], xor_mapped_addr=[1.17.28.40:46019]

New Log Line: Relay address is printed when session closed with allocation timeout.
INFO: session 002000000000000017: closing 172.21.193.10:42908 reason: allocation timeout

@korayvt
Copy link
Contributor Author

korayvt commented Mar 20, 2024

Hi @eakraly,

Do you have any comments on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants