Use log4cplus(#1344) #1351
Use log4cplus(#1344) #1351
Conversation
KangLin
force-pushed
the
log4cplus
branch
19 times, most recently
from
f37f39f
to
2e6c64d
Compare
|
syslog and friends are pretty easy to write to. If you want to stick to C, just came across this https://codeberg.org/RafaGago/mini-async-log-c |
|
Thanks @SamuelMarks for recommending. In O&M, the function of output to the log server is very important too. |
|
It would ideal if this PR could be adjusted to put the various logging actions behind macros that are generic enough to be implemented with different backends. My $dayjob uses our own in-house logging system where we have a lot of tooling around the specific log file binary format that we produce. It would be very nice to see this changelist use macros for every place that log statements are called so that I could drop my own logging system into place without having to touch every file. |
|
Please see ci
在 2024-01-20 00:30:46，"Michael Jones" ***@***.***> 写道：
@jonesmz commented on this pull request.
In .github/workflows/tests.yml:
@@ -30,7 +30,8 @@ jobs:
libpq-dev libsqlite3-dev \
libhiredis-dev \
libmongoc-dev \
- libmicrohttpd-dev
+ libmicrohttpd-dev \
+ liblog4cplus-dev
I don't see how this change, and the change to Dockerfile, have anything to do with the change to the run_tests.sh program?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I'm hoping to drop the makefile from the next major release.maintenance is too painful.
在 2024-01-20 00:32:11，"Michael Jones" ***@***.***> 写道：
@jonesmz commented on this pull request.
In Makefile.in:
MAKE_DEPS = Makefile
…-LIBCLIENTTURN_HEADERS = src/ns_turn_defs.h src/client++/TurnMsgLib.h src/client/ns_turn_ioaddr.h src/client/ns_turn_msg.h src/client/ns_turn_msg_defs.h src/client/ns_turn_msg_defs_experimental.h src/client/ns_turn_msg_addr.h
-LIBCLIENTTURN_MODS = src/client/ns_turn_ioaddr.c src/client/ns_turn_msg_addr.c src/client/ns_turn_msg.c
-LIBCLIENTTURN_DEPS = ${LIBCLIENTTURN_HEADERS} ${MAKE_DEPS}
These are a lot of changes to make for just adding a single library.
Is it practical to break this change down into multiple commits so that they can be more easily reviewed?
I support refactoring the makefile to be more expressive and flexible, but not when a change like that is mixed in with adding new stuff.
Ideally you would have
one or more commits that refactors the makefile
one commit that adds the new library.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Forget why. It could be to keep the latest version.
在 2024-01-20 00:33:05，"Michael Jones" ***@***.***> 写道：
@jonesmz commented on this pull request.
In .github/workflows/msvc.yml:
@@ -39,7 +39,7 @@ jobs:
SOURCE_DIR: ${{github.workspace}}\.cache\source
TOOLS_DIR: ${{github.workspace}}\.cache\tools
INSTALL_DIR: ${{github.workspace}}\.cache\install_msvc_${{matrix.triplet}}_${{matrix.BUILD_TYPE}}
- VCPKGGITCOMMITID: acc3bcf76b84ae5041c86ab55fe138ae7b8255c7
+ VCPKGGITCOMMITID: 0e47c1985273129e4d0ee52ff73bed9125555de8
Can you elaborate on why you're changing VCPKGGITCOMMITID ?
most likely this change to the commitid should be done as a stand-alone commit.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Machine translated. Is the grammar wrong?
original:
此项目包括两种日志实现:
- 用成熟的日志库[log4cplus](https://github.com/log4cplus/log4cplus)
- 本库原有的日志实现 [陈旧的]
在 2024-01-20 00:34:01，"Michael Jones" ***@***.***> 写道：
@jonesmz commented on this pull request.
In docs/Log.md:
@@ -0,0 +1,352 @@
+# Log
+
+This project includes the following two types of log implementations:
+
+- Use a mature logging library. current use [log4cplus](https://github.com/log4cplus/log4cplus)
+- The project is implemented on its own [Discarded]
I'm not understanding this sentence. Can you reword it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
You have changes in a single commit that aren't related to each other
I was asking about it because it would be nice to have the commits broken
up into more logical changes.
…On Fri, Jan 19, 2024, 19:05 Kang Lin ***@***.***> wrote:
Please see ci
在 2024-01-20 00:30:46，"Michael Jones" ***@***.***> 写道：
@jonesmz commented on this pull request.
In .github/workflows/tests.yml:
> @@ -30,7 +30,8 @@ jobs:
libpq-dev libsqlite3-dev \
libhiredis-dev \
libmongoc-dev \
- libmicrohttpd-dev
+ libmicrohttpd-dev \
+ liblog4cplus-dev
I don't see how this change, and the change to Dockerfile, have anything
to do with the change to the run_tests.sh program?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub
<#1351 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFYQR2Y6KD52Z7OUYKHVTDYPMJ4VAVCNFSM6AAAAABAZDBKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGUYTOMRYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It is a single commit! |
log4cplus:
If you want to stick with C, After this PR(log4cplus/log4cplus#607) is accepted by log4cplus, the .cpp will no longer appear in the source code.