This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
[greenboard] Adds Deposit scenario #2135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
…nto joel/e2e-deposit
joelalejandro
changed the title
joelalejandro
requested review from
Alonski,
cf19drofxots,
ebryn,
ldct,
briarsweetbriar and
snario
as code owners
|
Waiting on #2102 to be merged to prevent test selector conflicts. |
6 tasks
|
@spersico can you pick up where I left off on this PR? It'd be great to add a second flow where the user attempts to deposit with an ERC20 token instead of ETH. Don't worry too much about the conflicts; I'm |
|
Yes! Sure!
El mié., 14 de agosto de 2019 11:25, Joel Alejandro Villarreal Bertoldi <
notifications@github.com> escribió:
… @spersico <https://github.com/spersico> can you pick up where I left off
on this PR? It'd be great to add a second flow where the user attempts to
deposit with an ERC20 token instead of ETH.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2135?email_source=notifications&email_token=ACQEDTLHWYAK5J5NKA7UKVDQEQIULA5CNFSM4IJPFOZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4I6XIY#issuecomment-521268131>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQEDTPAWRWE4BSH3VNVZ2TQEQIULANCNFSM4IJPFOZA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following scenarios:
Contributes to #1852.