Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

717 jwt dpop #763

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

717 jwt dpop #763

wants to merge 29 commits into from

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jul 7, 2023

Implement resource server part of OAuth2 DPoP


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Jul 7, 2023 that may be closed by this pull request
@johakoch
Copy link
Collaborator Author

@malud https://codeclimate.com/github/coupergateway/couper/pull/763
codeclimate again :-(
The DPoP proof JWT claims contain at least 4 claims that must be validated (1 error return each) (+ the regular return). That makes more than the allowed 4.
Do I have to group them by 2, just to please codeclimate?

@johakoch johakoch marked this pull request as ready for review April 10, 2024 06:20
@johakoch
Copy link
Collaborator Author

I successfully checked the validation of a DPoP token obtained by okta-auth-js (which in version 7.7.0 supports DPoP) from an okta org authorization server and passed to a resource server protected by couper with this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT AC: Implement DPoP auth scheme
1 participant