Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrride evicted task #170 #75

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timo-schmid
Copy link

@timo-schmid timo-schmid commented May 29, 2019

Some shortcomings, for now

  • reverseDependencies doesn't seem to contain the versions, so some of them are missing
  • val conflicts: Seq[Conflict] = Conflict(resolution) returns an empty Seq, not sure why. It would be much nicer to use this.
  • The test is not yet very useful

@timo-schmid
Copy link
Author

timo-schmid commented May 29, 2019

I did some more research:

  • reverseDependencies doesn't return the versions by design. Not sure why, but it's definitely inteded.
  • Conflict(resolution) will not return dependencies, that are set explicitly, e.g.:
libraryDependencies ++= Seq(
  "org.slf4s" %% "slf4s-api" % "1.7.12",         // depends on org.slf4j:slf4j-api:1.7.12
  "ch.qos.logback" % "logback-classic" % "1.1.2" // depends on org.slf4j:slf4j-api:1.7.6
)
// yields
// [warn] Using org.slf4j:slf4j-api:1.7.12 over 1.7.6
// [warn] (wanted by ch.qos.logback:logback-classic:1.1.2)

and

libraryDependencies ++= Seq(
  "org.typelevel" %% "cats-effect" % "1.3.1", // depends on cats-core 1.6.0
  "org.typelevel" %% "cats-core" % "1.5.0"
)
// yields no warnings

I'm not sure this is the expected behaviour for the evicted task. I think the evicted task should show all the dependencies that were "changed" in the process. Correct me if I'm wrong on that.

So my suggestion would be to add a parameter to coursier.graph.Conflict.apply to control whether or not to show all evicted dependencies. Is that a good solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant