Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jarjar-abrams to 1.14.0 #45

Merged
merged 1 commit into from Mar 18, 2024

Conversation

BardurArantsson
Copy link
Contributor

@BardurArantsson BardurArantsson commented Mar 18, 2024

My use case is that I'd like to use ShadingRules.Zap which was added in a later version of jarjar than the only currently in use in sbt-shading.

Btw, I'm seeing some stuff like

Expected class name: argonaut.Json
Class name: foo.shaded.argonaut.Json
Exception in thread "main" java.lang.RuntimeException: Expected class name argonaut.Json, got foo.shaded.argonaut.Json
        at scala.sys.package$.error(package.scala:27)

from some of the scripted tests, but they run without failure. Not sure if that's a problem or if it's to be expected.

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok, let's merge it

@tgodzik tgodzik merged commit db53aeb into coursier:master Mar 18, 2024
2 checks passed
@BardurArantsson BardurArantsson mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants