fix(theme, Mantine): remove labelWrapper style for checkbox #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiheon
requested review from
a team,
GermainBergeron and
SimonMilord
and removed request for
a team
SimonMilord
approved these changes
Nov 11, 2022
|
Since this fix has been merged and released in 5.7.2, it would be interesting to see if your fix still applies. And also see if we can remove the theme style added for the radio buttons |
Indeed 😄 I'll try again to make the bump, maybe what broke the ModalWizard in 5.7.0 was also fixed in 5.7.2 🙈 😆 |
GermainBergeron
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
UITOOL-1020
Currently, the checkbox label and description are all on the same line but they should not so i'm removing the custom style.
Potential Breaking Changes
None
Acceptance Criteria