Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce npm usage #578

Merged
merged 5 commits into from Nov 29, 2022
Merged

chore: enforce npm usage #578

merged 5 commits into from Nov 29, 2022

Conversation

louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Nov 28, 2022 •
edited

  • Added corepack support to 'help' usage of the right package manager.
  • At the CI-level, forbid the presence of pnpm and yarn lockfiles.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

BONUS: For the duration of the Centraide Campain 2022, author of unconventional commit on master will be strongly invited to amend by making a donation to Centraide ❤️

@louis-bompart louis-bompart changed the title No pnpm chore: enforce npm usage Nov 28, 2022
@louis-bompart louis-bompart marked this pull request as ready for review November 28, 2022 19:13
@louis-bompart louis-bompart requested review from a team as code owners November 28, 2022 19:13
@louis-bompart
Copy link
Contributor Author

louis-bompart commented Nov 28, 2022 •
edited

See this to see what core.error is doing
image

@louis-bompart louis-bompart enabled auto-merge (squash) November 28, 2022 19:30
@louis-bompart
Copy link
Contributor Author

While using corepack, the error that's displayed when the wrong packagemanager is used will be 'meh' till

But it'll still fail succesfully

toofff
toofff approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-bompart louis-bompart merged commit 4488834 into master Nov 29, 2022
@louis-bompart louis-bompart deleted the no-pnpm branch November 29, 2022 01:40
@github-actions
Copy link

🎉 This PR is included in version 37.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toofff toofff toofff approved these changes

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/admin-console

@SimonMilord SimonMilord Awaiting requested review from SimonMilord SimonMilord is a code owner automatically assigned from coveo/admin-console

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-bompart @toofff @y-lakhdar