Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(caseclassificationconfiguration): add new endpoints for document… #821

Merged
merged 1 commit into from
May 14, 2024
Merged

feat(caseclassificationconfiguration): add new endpoints for document… #821

merged 1 commit into from
May 14, 2024

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented May 13, 2024 •
edited

Add new endpoints for valueCount and documentCount

  • Both the new endpoints accept an advancedQuery or the properties set by a 'standard mode configuration'

MLCONFIG-188 <-- API info in the ticket

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

LucaCogliandroCoveo
LucaCogliandroCoveo reviewed May 13, 2024
View reviewed changes
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
...MachineLearning/CaseClassificationConfiguration/CaseClassificationConfigurationInterfaces.ts Outdated Show resolved Hide resolved
@lprovost-coveo lprovost-coveo force-pushed the feature/MLCONFIG-188 branch 2 times, most recently from e53a73b to bb2ed82 Compare May 13, 2024 19:43
@lprovost-coveo lprovost-coveo marked this pull request as ready for review May 13, 2024 19:47
@lprovost-coveo lprovost-coveo requested review from a team as code owners May 13, 2024 19:47
@lprovost-coveo lprovost-coveo added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit 238d542 May 14, 2024
5 checks passed
@lprovost-coveo lprovost-coveo deleted the feature/MLCONFIG-188 branch May 14, 2024 18:40
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 54.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaCogliandroCoveo LucaCogliandroCoveo LucaCogliandroCoveo left review comments

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@paulgerold paulgerold paulgerold approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier dmgauthier is a code owner automatically assigned from coveo/admin-console

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lprovost-coveo @GermainBergeron @paulgerold @LucaCogliandroCoveo