Format forcing does not bypass valid file check

[littleforest]

Problem

In v0.6.9, the Coverage.py coverage executable was not being used to parse the python-generated .coverage file. With the release of v0.6.10, the Coverage.py coverage executable became required if attempting to parse a .coverage file. If a user has a .coverage file but does not have the coverage executable installed, then a debug error message is output informing them to either install coverage, or to convert the file to coverage.xml and force the cobertura format.

However, when forcing a format, the system still collects all possible coverage files across all file types, and passes them directly to the specified parser, bypassing the parser's matches? method that checks to make sure that the file is of a valid format. This is long standing behavior (and a long-standing bug), but did not surface until recently (coverallsapp/github-action#205), due to the fact that users ended up with both a coverage.xml file and a .coverage file in their directory, but were forcing the cobertura format. The error occurred when the Cobertura parser tried to parse the .coverage file.

⚡ Solution

If a user specifies a format, then only the files that match the glob-pattern for the specified parser will be passed to the parser. In addition, the matches? method is no longer bypassed, which ensures that even if a file matches the correct naming pattern, there will be no attempt to parse it if the actual file format is incorrect.

If a user specifies the python format for a .coverage file, but does not have the coverage executable installed, then an error will be raised. If no format is specified, and the user has a .coverage file but does not have the coverage executable installed, then a debug warning message only will be displayed.

[coveralls-official]

Pull Request Test Coverage Report for Build 8931836762

Details

• 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.07%) to 93.971%

---

Totals
Change from base Build 8804286293:	0.07%
Covered Lines:	904
Relevant Lines:	962

---

💛 - Coveralls

[mike-burns]

Great solution, thanks for figuring out those tests too.

[mike-burns]

👍

[afinetooth]

I agree with Mike, great solution. Thanks so much. Looks good to me.