Automate alert push notification tests #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both push and notifications are tested under the jest framework Tests with e2e.spec.js are not run by default but are run when jest is run with the JEST_PROJECT=e2e environment variable
ptbrowne
force-pushed
the
push-notif-e2e
branch
from
68cf5d9
to
9595f48
Compare
drazik
reviewed
Jan 3, 2020
drazik
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push notifications E2E tests were semi automatic since we had
to start the mock push notification server and compare the requests
received to what was expected.
Now the tests are automatic:
compared to what's expected