feat: Allow app to adapt normalization on realtime #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Oct 30, 2023
| * @returns {null} The component does not display anything. | ||
| */ | ||
| const RealTimeQueries = ({ doctype }) => { | ||
| const RealTimeQueries = ({ doctype, customNormalization }) => { |
There was a problem hiding this comment.
Nice! Maybe we should have the ability to customize the "normalization" by event (create / update / delete).
Also, I would have done that outside of the normalization step, because here it's not a normalization anymore, it's a "business logical" before dispatching the result.
I didn't have a good naming yet, but :
customComputeDocumentFromRealtime can be more appropriated?
In fact, we already have this computeDocumentFromRealtime without knowing it... :
{ ...couchDBDoc, _deleted: true },
So this one cas ben the default on deleteEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly to share my progress for the moment