Add helpers to generate paper expiration date message #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zatteo
force-pushed
the
feat/migrate-expiration-data
branch
from
98a1b3c
to
f465dc8
Compare
JF-Cozy
approved these changes
Apr 24, 2024
paultranvan
approved these changes
Apr 24, 2024
| @@ -435,3 +437,46 @@ export const formatContactValue = contacts => { | |||
| ? contacts.map(contact => `${getDisplayName(contact)}`).join(', ') | |||
| : '' | |||
| } | |||
|
|
|||
| /** | |||
| * @param {Object} options - Options | |||
There was a problem hiding this comment.
What could we do without you, jsdoc
| const t = getLocalizer(lang) | ||
|
|
||
| const distance = formatDistanceToNowStrict(new Date(expirationDate), { | ||
| locale: lang === 'fr' ? fr : undefined |
There was a problem hiding this comment.
What happens when the locale is undefined?
There was a problem hiding this comment.
I will add a comment to explain it. It fallbacks to english by default.
zatteo
force-pushed
the
feat/migrate-expiration-data
branch
from
f465dc8
to
2692c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work done here #1452 to mutualize logic for paper formatting, we mutualize logic for paper expiration date message like 'Expired' or 'Expires in 10 days'.
We will use these helpers in :