Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Contacts): Func getPrimaryOrFirst should not crash for array of null #1469

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Apr 25, 2024

Suite à un bug dans un service récemment ajouté côté Contacts, on se retrouve potentiellement avec des contacts qui ont, pour les champs address/phone/cozy/email un [null]. Ce qui fait cracher ces méthodes.

@Merkur39
Copy link
Member

Ca devrait corriger mais c'est quand même étrange(pas normal?) de se retrouver avec un tableau du null ou undefined sur ces attributs 🤔

@JF-Cozy
Copy link
Contributor Author

JF-Cozy commented Apr 25, 2024

je rajoute une description pour avoir du contexte 👍

@JF-Cozy JF-Cozy merged commit 3e4061a into master Apr 25, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the fix/contacts branch April 25, 2024 10:26
JF-Cozy added a commit to cozy/cozy-contacts that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants