feat: Do not hydrate document with empty relationship data #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of document hydration,
from now on the document will no longer be hydrated
with relationships that have no data.
Example:
```
const schema = {
...
relationships: {
books: {
type: 'has-many',
doctype: "io.cozy.books"
},
authors: {
type: 'has-many',
doctype: "io.cozy.authors"
}
}
}
{
_id: "my_doc",
relationships: {
books: {
data: [{ _id: "01", _type: "io.cozy.books" }]
}
}
}
```
will be hydrated as follows:
```
{
_id: "my_doc",
books: <HasMany object>,
relationships: {
books: {
data: [{ _id: "01", _type: "io.cozy.books" }]
}
}
}
```
instead of :
```
{
_id: "my_doc",
books: <HasMany object>,
authors: <HasMany object>,
relationships: {
books: {
data: [{ _id: "01", _type: "io.cozy.books" }]
}
}
}
```
Merkur39
requested review from
nono,
doubleface,
taratatach,
Ldoppea,
cballevre,
zatteo,
acezard and
JF-Cozy
|
I'm closing this, the approach isn't good. It's probably better to act on the "dehydrate" methods instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR propose un changement important dans le comportement de l'hydratation des documents! (voir le message de commit)