feat(getEmojiByCountry): Automatically generate flag emoji #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
changed the title
JF-Cozy
approved these changes
May 15, 2024
| import logger from '../../logger' | ||
|
|
||
| // The offset between uppercase ASCII and regional indicator symbols | ||
| const offset = 127397 |
There was a problem hiding this comment.
comme c'est une constante on pourrait l'茅crire un OFFSET et peut-锚tre trouver un nom moins g茅n茅rique 馃
There was a problem hiding this comment.
Ok, let's go to UNICODE_OFFSET.
paultranvan
reviewed
May 15, 2024
|
|
||
| let emojiCountry | ||
| if (country === 'stranger') { | ||
| emojiCountry = t('country.stranger') |
There was a problem hiding this comment.
It looks weird to have a locale in the emojiCountry. Why not something like this?
const emojiCountry = country !== 'stranger' ? getEmojiByCountry(country) : null
const countryLabel = country === 'stranger' ? t('country.stranger') : label
return emojiCountry
? `${t(countryLabel, newOpts)} ${emojiCountry}`
: t(countryLabel, newOpts)There was a problem hiding this comment.
Indeed, it looks better 馃憤
There was a problem hiding this comment.
I've set it as below so as not to change the existing return.
const emojiCountry = country !== 'stranger' ? getEmojiByCountry(country) : null
const strangerLabel = country === 'stranger' ? t('country.stranger') : null
return emojiCountry || strangerLabel
? `${t(label, newOpts)} ${emojiCountry || strangerLabel}`
: t(label, newOpts)
This new implementation automatically generates flag emoji.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves flag emoji generation 馃帀
Necessary development for ongoing development on MesPapiers