Upgrade d3 #11090
Upgrade d3 #11090
Conversation
# Conflicts: # package-lock.json # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.LICENSE.txt # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/src/js/Chart.js # src/web/assets/d3/webpack.config.js # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/tailwindreset/dist/css/tailwind_reset.css.map
timkelty
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
|
Is there a chance that this will get accepted and a more recent version of d3 will be included with Craft? I have a plugin idea that requires d3 ^6.6.1, which conflicts with the current version that ships with Craft (4.13.0). To get it to work, I have to render on a page outside of the Craft CP, whereas I would love to be able to get it to work in a CP page. Alternatively, is there a way of forcing a newer version of d3 to load on a specific CP page? |
|
@steverowling It would be a breaking change so will happen for Craft 5 instead. |
# Conflicts: # package-lock.json # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/d3/dist/d3-format/locale/ru-RU.json # src/web/assets/garnish/dist/garnish.js.map # src/web/assets/graphiql/dist/graphiql.js # src/web/assets/graphiql/dist/graphiql.js.map # src/web/assets/pluginstore/dist/js/app.js.map # src/web/assets/upgrade/dist/UpgradeUtility.js.map
|
@timkelty May be the fault of my merge commit but I’m getting |
|
@brandonkelly not seeing any errors in my console 🤔 FWIW - |
# Conflicts: # package-lock.json # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/dashboard/dist/Dashboard.js.map # src/web/assets/garnish/dist/garnish.js.map # src/web/assets/graphiql/dist/graphiql.js # src/web/assets/graphiql/dist/graphiql.js.map # src/web/assets/htmx/dist/htmx.min.js # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/pluginstore/dist/js/app.js # src/web/assets/pluginstore/dist/js/app.js.LICENSE.txt # src/web/assets/pluginstore/dist/js/app.js.map # src/web/assets/tailwindreset/dist/css/tailwind_reset.css # src/web/assets/upgrade/dist/UpgradeUtility.js.map # src/web/assets/vue/dist/vue.js # src/web/assets/vue/dist/vue.js.LICENSE.txt
|
Closed in favor of #14124 |
@brianjhanson Assigning this to you, just because you're closer to it at the moment, but happy to take it back, or go through it together.