Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to source navigation and element index UI, user-related document titles #14946

Open
wants to merge 12 commits into
base: 5.2
Choose a base branch
from
Open

Changes to source navigation and element index UI, user-related document titles #14946

wants to merge 12 commits into from

Conversation

gcamacho079
Copy link
Contributor

Description

A couple of new changes:

  • To communicate context inside an element index on the mobile layout when the sidebar is closed, the source name has been added to the h1 (see screenshot).
  • On the mobile element index layout, the sidebar is kept open on source selection to prevent focus from being dropped (Resolves PT-1303)
  • User page document titles have been updated to describe the page purpose (Resolves PT-1701)
Element index screen on mobile. The h1 includes the source name so that users are aware of the active source when the sidebar is initially toggled close.

Related issues

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label May 6, 2024
@linear Linear
Copy link

linear bot commented May 6, 2024

PT-1303 Because the source sidebar is hidden on source selection, focus is lost when choosing a source in mobile view

PT-1701 User account page titles do not reflect page purpose

brianjhanson
brianjhanson approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@brianjhanson brianjhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the styling just a bit, but otherwise looks good!

CleanShot 2024-05-21 at 11 32 16

@gcamacho079
Copy link
Contributor Author

I adjusted the styling just a bit, but otherwise looks good!

Thanks, @brianjhanson; I like the adjustments you made! 💯

@brandonkelly
Move the release notes to the WIP changelog and tweak wording
4520e24 
[ci skip]
@brandonkelly
Merge branch '5.2' into a11y/secondary-nav
81b3356 
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly
Copy link
Member

Is this / after “My Account” intentional?

Screenshot of the top of the My Account page on mobile

@brianjhanson
Copy link
Contributor

@brandonkelly nope. Fixed in cd6a015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjhanson brianjhanson brianjhanson approved these changes

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees
No one assigned
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcamacho079 @brandonkelly @brianjhanson