Add libhvee as alternative Hyper-V driver on Windows #3824

gbraad · 2023-09-06T10:20:42Z

Basic functionality for:

create
start
stop
delete

openshift-ci · 2023-09-06T10:20:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gbraad. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adrianriobo · 2023-10-05T19:30:23Z

These are the results for this PR on windows https://crcqe-asia.s3.amazonaws.com/nightly/ocp/4.13.12/20231005/11-pro/qe-results/e2e-non-ux.xml all green except the known issue with the latest version for the pipelines operator

gbraad · 2023-10-06T09:49:21Z

Want to incorporate 9P, but the current codebase for this lives in the PR containers/gvisor-tap-vsock#280

cfergeau · 2023-10-06T10:31:52Z

Want to incorporate 9P, but the current codebase for this lives in the PR containers/gvisor-tap-vsock#280

The code from this gvisor-tap-vsock PR is short, and thus easy to add to the daemon when we need it. But there's also some guest code involved, which might be trickier mheon/libpod@334e213

gbraad · 2023-10-06T15:04:22Z

@cfergeau it basically is the same/similar code as the 9p-ufs that I tested with earlier, so I am not so concerned. I am more curious if this will therefore be part of a library, or the changes for libpod remain seperate?

gbraad · 2023-10-17T06:28:41Z

ref: #3870

cfergeau

I've rebased this and squashed the commits in https://github.com/cfergeau/crc/tree/libhvee
This looks like a fairly straightforward change, though I haven't tried running it on a Windows machine :)

cfergeau · 2023-10-31T16:24:57Z

pkg/crc/preflight/preflight_checks_windows.go

@@ -166,19 +165,6 @@ func fixUserPartOfCrcUsersAndHypervAdminsGroup() error {
 	return errReboot
 }

-func checkIfHyperVVirtualSwitchExists() error {


Fwiw, it would be good to split the system mode networking removal on Windows in its own preparatory commit, this would make it easier to focus on/review the config/preflight changes.

Honestly, I do not even know if this functionality still works. I'll consider, but these checks are also performed when not even necessary (like the existence of the virtual switch) and therefore actually wrong.

I've done this in https://github.com/cfergeau/crc/tree/libhvee, this removes even more code

pkg/drivers/libhvee/libhvee_windows.go

cfergeau · 2024-05-15T08:29:58Z

Given #3870 (comment) , I'd punt 9p support for now and work on merging the libhvee code with no changes to the file sharing code.

Maybe we need to use https://github.com/aperezdc/9pfuse?tab=readme-ov-file or something similar.

gbraad · 2024-05-15T10:19:57Z

work on merging the libhvee code with no changes to the file sharing code.

Do you mean to target SMB or leave as in the current PR (no support)

cfergeau · 2024-05-15T10:24:38Z

work on merging the libhvee code with no changes to the file sharing code.

Do you mean to target SMB or leave as in the current PR (no support)

Ideally, use the same SMB support as what we have now. I haven't checked if this PR removes some SMB support, but hopefully it's still there?

gbraad · 2024-05-15T10:49:19Z

Originally the PR removed it, but part of it is there... just never tested. Note: we have no automated tests for this :-s.

anjannath · 2024-05-21T07:56:02Z

Tested this PR on windows and the SMB based file sharing and it is working as expected, have to use the windows MSI installer, then the following config options needs to be set before crc start

$ crc config set host-network-access true
$ crc config set shared-dir-password <login_user_pass>
$ crc config set enable-shared-dir true

anjannath · 2024-05-21T09:55:36Z

While testing i also noticed that error messages from the libhvee driver is a bit concise than the older hyperv driver, e.g

from libhvee..

from hyperv driver

gbraad · 2024-05-29T03:48:11Z

@anjannath this is a side effect of the WMI use. The powershell interface is more verbose, though also not always right. When WMI is used, you only get return codes back from the 'queries' and 'requests' that are performed. This would need to be a refinement in the libhvee library. Perhaps file an issue upstream for this?

gbraad · 2024-05-29T03:48:37Z

/me tested and concludes: "works as expected"

Should return an error when trying to set the "system networking" option. But I think this is already the case, or it's not possible to choose this option in release builds? Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

This replaces the interaction of Hyper-V from our machine-drivers based driver as used in Minikube/minishift to the libhvee library as used by podman machine.

Disk handling API was added to libhvee since the first iteration of the libhvee support, we can now make use of it. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

openshift-ci · 2024-05-29T12:16:53Z

@gbraad: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`0a0ad63`	link	false	`/test security`
ci/prow/integration-crc	`0a0ad63`	link	true	`/test integration-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress label Sep 6, 2023

openshift-ci bot requested review from anjannath and evidolob September 6, 2023 10:20

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch 6 times, most recently from 9c10def to 2e72ce2 Compare September 11, 2023 06:51

gbraad changed the title ~~[WIP] fixes #3811 add libhvee as alternative Hyper-V driver on Windows~~ Add libhvee as alternative Hyper-V driver on Windows Sep 11, 2023

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 11, 2023

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 0a919ec to 6013d5f Compare September 13, 2023 06:54

This comment was marked as outdated.

Sign in to view

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 6013d5f to d1658c1 Compare September 13, 2023 08:13

gbraad added size/M priority/major os/windows labels Sep 19, 2023

gbraad self-assigned this Sep 19, 2023

gbraad requested review from praveenkumar and cfergeau September 19, 2023 10:29

openshift-merge-robot added the needs-rebase label Oct 6, 2023

gbraad mentioned this pull request Oct 6, 2023

Add support for volume sharing via gvproxy for HyperV containers/gvisor-tap-vsock#280

Closed

cfergeau reviewed Oct 31, 2023

View reviewed changes

gbraad mentioned this pull request Nov 2, 2023

Removing unneeded code containers/libhvee#59

Merged

cfergeau removed the do-not-merge/work-in-progress label May 14, 2024

cfergeau closed this May 15, 2024

cfergeau deleted the gbraad/spike-add-libhvee-as-alternative-3811 branch May 15, 2024 08:28

cfergeau restored the gbraad/spike-add-libhvee-as-alternative-3811 branch May 15, 2024 08:29

cfergeau reopened this May 15, 2024

openshift-ci bot added the do-not-merge/work-in-progress label May 15, 2024

openshift-merge-robot added the needs-rebase label May 15, 2024

cfergeau force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from a9c936a to 6321f26 Compare May 15, 2024 08:29

openshift-merge-robot removed the needs-rebase label May 15, 2024

cfergeau mentioned this pull request May 16, 2024

Implement 9P client support for libhvee #4168

Open

adrianriobo mentioned this pull request May 21, 2024

[QE] Add test scenario for file sharing #4172

Open

gbraad mentioned this pull request May 28, 2024

Switch to UEFI for vfkit driver #4180

Open

openshift-merge-robot added the needs-rebase label May 29, 2024

windows: Remove system networking

e95d55f

Should return an error when trying to set the "system networking" option. But I think this is already the case, or it's not possible to choose this option in release builds? Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 6321f26 to 394e34e Compare May 29, 2024 04:56

openshift-merge-robot removed the needs-rebase label May 29, 2024

gbraad changed the title ~~[WIP] Add libhvee as alternative Hyper-V driver on Windows~~ Add libhvee as alternative Hyper-V driver on Windows May 29, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label May 29, 2024

gbraad and others added 2 commits May 29, 2024 11:47

Use libhvee instead of the current PowerShell cmdlet implementation

f3a8f07

This replaces the interaction of Hyper-V from our machine-drivers based driver as used in Minikube/minishift to the libhvee library as used by podman machine.

libhvee: Use libhvee APIs for disk resize

0a0ad63

Disk handling API was added to libhvee since the first iteration of the libhvee support, we can now make use of it. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>

cfergeau force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 394e34e to 0a0ad63 Compare May 29, 2024 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add libhvee as alternative Hyper-V driver on Windows #3824

Add libhvee as alternative Hyper-V driver on Windows #3824

gbraad commented Sep 6, 2023 •

edited

openshift-ci bot commented Sep 6, 2023

This comment was marked as outdated.

adrianriobo commented Oct 5, 2023 •

edited

gbraad commented Oct 6, 2023

cfergeau commented Oct 6, 2023

gbraad commented Oct 6, 2023

gbraad commented Oct 17, 2023

cfergeau left a comment

cfergeau Oct 31, 2023

gbraad Jan 24, 2024

cfergeau Apr 8, 2024

cfergeau commented May 15, 2024

gbraad commented May 15, 2024

cfergeau commented May 15, 2024

gbraad commented May 15, 2024

anjannath commented May 21, 2024

anjannath commented May 21, 2024

gbraad commented May 29, 2024

gbraad commented May 29, 2024

openshift-ci bot commented May 29, 2024 •

edited

Add libhvee as alternative Hyper-V driver on Windows #3824

Are you sure you want to change the base?

Add libhvee as alternative Hyper-V driver on Windows #3824

Conversation

gbraad commented Sep 6, 2023 • edited

openshift-ci bot commented Sep 6, 2023

This comment was marked as outdated.

adrianriobo commented Oct 5, 2023 • edited

gbraad commented Oct 6, 2023

cfergeau commented Oct 6, 2023

gbraad commented Oct 6, 2023

gbraad commented Oct 17, 2023

cfergeau left a comment

Choose a reason for hiding this comment

cfergeau Oct 31, 2023

Choose a reason for hiding this comment

gbraad Jan 24, 2024

Choose a reason for hiding this comment

cfergeau Apr 8, 2024

Choose a reason for hiding this comment

cfergeau commented May 15, 2024

gbraad commented May 15, 2024

cfergeau commented May 15, 2024

gbraad commented May 15, 2024

anjannath commented May 21, 2024

anjannath commented May 21, 2024

from libhvee..

from hyperv driver

gbraad commented May 29, 2024

gbraad commented May 29, 2024

openshift-ci bot commented May 29, 2024 • edited

gbraad commented Sep 6, 2023 •

edited

adrianriobo commented Oct 5, 2023 •

edited

openshift-ci bot commented May 29, 2024 •

edited