Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disk resize to work with lvms-storage-operator/topolvm #4114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anjannath
Copy link
Member

@anjannath anjannath commented Apr 9, 2024

fixes #4117

needs crc-org/snc#877

@openshift-ci openshift-ci bot requested review from cfergeau and gbraad April 9, 2024 12:30
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anjannath. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/crc/config/settings.go Outdated Show resolved Hide resolved
cmd/crc/cmd/start.go Outdated Show resolved Hide resolved
@anjannath
Copy link
Member Author

this PR is not needed anymore, the snc PRs:

  1. add LVMS operator to openshift cluster snc#869
  2. add LVMS operator to openshift cluster snc#869
    will take care of all the steps needed to install topolvm entirely on snc

after using topolvm as storage provisioner there's
two partitions of type xfs and its ambiguos  which
is the root partition but the root partition  also
has a label 'root' in case of the ocp bundle
@praveenkumar
Copy link
Member

/wip

@praveenkumar
Copy link
Member

/hold

this allows users to also configure the persistent volume's partition
size for the ocp preset, in case of ocp preset the default size of the
persistent volume partition (topolvm partition) is 3G
@anjannath anjannath force-pushed the extradisk branch 2 times, most recently from 55b2b61 to 92fa114 Compare June 3, 2024 15:03
this adds code to move topolvm partition and restart
the VM which is needed to re-read the changed partition
table, after moving the topolvm partition the root partition
can be grown

since the pv storage is on a separate parition users can also
configure its size using the 'persistent-volume-size' config
this makes it a bit easier to navigate the start.go file by moving
some of the disk size and partition modification functions into  a
separate disks.go file in the same machine package
@anjannath anjannath changed the title Install LVMCluster resource during crc start Update disk resize to work with lvms-storage-operator/topolvm Jun 6, 2024
Copy link

openshift-ci bot commented Jun 6, 2024

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 92fa114 link true /test e2e-microshift-crc
ci/prow/e2e-crc 92fa114 link true /test e2e-crc
ci/prow/security efefed3 link false /test security
ci/prow/integration-crc efefed3 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Use LVM storage operator for dynamic PV provisioning
4 participants