Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove podman preset completely #4167

Merged
merged 4 commits into from
May 21, 2024

Conversation

praveenkumar
Copy link
Member

No description provided.

This reverts commit acd5fb4.
Since it is missed during 095fb5 one.
This reverts commit b7a922a.
It is missed during 095fb5 one
Till now we had some code to warn the user if they are using podman
preset, It has been around 3 releases since we start warning user that
it is going to removed. This PR is remove all the trace of it.
Copy link

openshift-ci bot commented May 16, 2024

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 967780f link false /test security
ci/prow/e2e-crc 967780f link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gbraad
Copy link
Contributor

gbraad commented May 20, 2024

@lilyLuLiu Have a look at:

https://github.com/crc-org/crc/blob/4e1a5b5180f3550f6c75b34d6b6574248eb56342/test/e2e/features/minimal.feature

I believe this testcase should now include a fail when the Podman preset is set. Hope you can look into this.

@praveenkumar praveenkumar merged commit 34074db into crc-org:main May 21, 2024
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants