Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd layer image corruption test #6204

Closed
wants to merge 1 commit into from
Closed

Readd layer image corruption test #6204

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

The test was originally introduced by testing via the PR: #5005

To avoid future regressions we now readd the test.

Which issue(s) this PR fixes:

Refers to containers/storage#1322

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 6, 2022
@openshift-ci openshift-ci bot added kind/ci Categorizes issue or PR as related to CI approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2022
@saschagrunert
Copy link
Member Author

CI seems to be broken in general :)

@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited

Codecov Report

Merging #6204 (b1d17d0) into main (6d66ea7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6204   +/-   ##
=======================================
  Coverage   43.68%   43.68%           
=======================================
  Files         122      122           
  Lines       13565    13565           
=======================================
  Hits         5926     5926           
  Misses       6999     6999           
  Partials      640      640

giuseppe
giuseppe approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Contributor

LGTM assuming happy tests

@saschagrunert
Readd layer image corruption test
b1d17d0 
The test was originally introduced by testing via the PR:
cri-o#5005

To avoid future regressions we now readd the test.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins b1d17d0 link true /test kata-containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-integration b1d17d0 link true /test ci-integration
ci/kata-jenkins b1d17d0 link true /test kata-containers
ci/prow/e2e-agnostic b1d17d0 link true /test e2e-agnostic
ci/prow/e2e-gcp b1d17d0 link true /test e2e-gcp
ci/prow/ci-rhel-integration b1d17d0 link true /test ci-rhel-integration
ci/prow/ci-fedora-integration b1d17d0 link true /test ci-fedora-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert saschagrunert deleted the layer-index-corruption-test branch January 17, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @TomSweeneyRedHat @openshift-ci-robot @giuseppe