Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] *: refactor createSandboxContainer to reduce cyclomatic complexity #7778

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] *: refactor createSandboxContainer to reduce cyclomatic complexity #7778

wants to merge 6 commits into from

Conversation

sohankunkerkar
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sohankunkerkar
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 22.04176% with 336 lines in your changes are missing coverage. Please review.

Project coverage is 47.97%. Comparing base (c692bec) to head (787e27f).
Report is 380 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7778      +/-   ##
==========================================
- Coverage   48.55%   47.97%   -0.59%     
==========================================
  Files         148      149       +1     
  Lines       16187    16209      +22     
==========================================
- Hits         7860     7776      -84     
- Misses       7366     7481     +115     
+ Partials      961      952       -9

@sohankunkerkar sohankunkerkar changed the title *: refactor createSandboxContainer to reduce cyclomatic complexity [WIP] *: refactor createSandboxContainer to reduce cyclomatic complexity Feb 13, 2024
@sohankunkerkar sohankunkerkar force-pushed the refactor-code branch 5 times, most recently from eb83668 to 5fece8f Compare February 15, 2024 14:41
@sohankunkerkar
server/*: use helper function to get details for user requested image
ce696f3 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
server: compute App ArmorProfile and Block IO details separately
35224c5 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
server: configure linux resources and security details separately
362075f 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
server: use helper function to compute SELinux relabel options
298cf9e 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
server: refactor createSandboxContainer to reduce cyclomatic complexity
e39d612 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
*: refactor mount-specific changes while creating a Sandbox container
787e27f 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 16, 2024
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp will be requested when the pull request is marked ready for review mrunalp is a code owner

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sohankunkerkar @openshift-merge-robot @haircommander