Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: misc swap fixes #7818

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

server: misc swap fixes #7818

wants to merge 1 commit into from

Conversation

haircommander
Copy link
Member

  • unify swap setting between update and create into one function
  • in create: don't rely on memory != 0 to set swap
  • in update: take into account memory swap values sent from kubelet

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a bug where on create a container wouldn't be given swap if memory is not specified, and on update swap wasn't taken into account

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@haircommander
server: misc swap fixes
b81d728 
- unify swap setting between update and create into one function
- in create: don't rely on memory != 0 to set swap
- in update: take into account memory swap values sent from kubelet

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 48.52%. Comparing base (6ff7c53) to head (b81d728).
Report is 236 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7818      +/-   ##
==========================================
- Coverage   48.53%   48.52%   -0.01%     
==========================================
  Files         148      148              
  Lines       16191    16195       +4     
==========================================
+ Hits         7858     7859       +1     
+ Misses       7368     7365       -3     
- Partials      965      971       +6

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 28, 2024
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp will be requested when the pull request is marked ready for review mrunalp is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@haircommander