-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace the built-in Go map with SwissMap in ResourceStore #8101
base: main
Are you sure you want to change the base?
[WIP] Replace the built-in Go map with SwissMap in ResourceStore #8101
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kwilczynski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bb69429
to
5728b5e
Compare
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
5728b5e
to
1636f8c
Compare
/retest |
@kwilczynski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8101 +/- ##
=======================================
Coverage 49.69% 49.69%
=======================================
Files 153 153
Lines 16826 16829 +3
=======================================
+ Hits 8361 8364 +3
Misses 7422 7422
Partials 1043 1043 |
/cc @bitoku |
@kwilczynski: GitHub didn't allow me to request PR reviews from the following users: bitoku. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign bitoku |
@kwilczynski: GitHub didn't allow me to assign the following users: bitoku. Note that only cri-o members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Warning
This is an experiment. Please keep this in mind when offering reviews.
TBA
Related:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?