Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace the built-in Go map with SwissMap in ResourceStore #8101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kwilczynski
Copy link
Member

@kwilczynski kwilczynski commented May 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Warning

This is an experiment. Please keep this in mind when offering reviews.

TBA

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner May 1, 2024 05:47
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 1, 2024
@kwilczynski kwilczynski changed the title Replace the built-in Go map with SwissMap in ResourceStore [WIP] Replace the built-in Go map with SwissMap in ResourceStore May 1, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2024
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 May 1, 2024 05:47
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign fidencio, sohankunkerkar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:
  • OWNERS [kwilczynski]

    Need more approvers for rest parts.

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski kwilczynski force-pushed the feature/replace-built-in-map-with-swissmap branch from bb69429 to 5728b5e Compare May 1, 2024 05:48
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/replace-built-in-map-with-swissmap branch from 5728b5e to 1636f8c Compare May 1, 2024 05:53
@kwilczynski
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented May 1, 2024

@kwilczynski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 1636f8c link true /test e2e-gcp-ovn
ci/prow/images 1636f8c link true /test images
ci/prow/e2e-aws-ovn 1636f8c link true /test e2e-aws-ovn
ci/prow/ci-cgroupv2-integration 1636f8c link true /test ci-cgroupv2-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.69%. Comparing base (43a95aa) to head (1636f8c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8101   +/-   ##
=======================================
  Coverage   49.69%   49.69%           
=======================================
  Files         153      153           
  Lines       16826    16829    +3     
=======================================
+ Hits         8361     8364    +3     
  Misses       7422     7422           
  Partials     1043     1043           

@kwilczynski kwilczynski self-assigned this May 1, 2024
@kwilczynski
Copy link
Member Author

/cc @bitoku

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@kwilczynski: GitHub didn't allow me to request PR reviews from the following users: bitoku.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bitoku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwilczynski
Copy link
Member Author

/assign bitoku

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@kwilczynski: GitHub didn't allow me to assign the following users: bitoku.

Note that only cri-o members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign bitoku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant