-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove registries
config and --registry
option
#8194
Conversation
Hi @bitoku. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8194 +/- ##
==========================================
- Coverage 49.54% 49.49% -0.05%
==========================================
Files 153 153
Lines 16961 17031 +70
==========================================
+ Hits 8403 8430 +27
- Misses 7511 7556 +45
+ Partials 1047 1045 -2 |
/ok-to-test |
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
/retest |
/test ci-cgroupv2-integration |
/approve |
/close |
@kwilczynski: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@kwilczynski: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test ci-fedora-kata |
/retest |
/approve |
@cri-o/cri-o-maintainers, can you give this another pass? Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test ci-cgroupv2-integration |
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
This PR removes
registries
config and--registry
optionWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
See #8161 for the context.
Does this PR introduce a user-facing change?