Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add js2bin-version-info #19

Closed
wants to merge 7 commits into from
Closed

Add js2bin-version-info #19

wants to merge 7 commits into from

Conversation

asamuzaK
Copy link
Contributor

Fix #17

@asamuzaK
Copy link
Contributor Author

asamuzaK commented Nov 12, 2020 •
edited

Ready for review.
NOTE: cron job is not added in this PR.

@asamuzaK asamuzaK mentioned this pull request Nov 12, 2020
Closed
@asamuzaK
Return promise chain
c11588e 
A try to avoid unhandledRejection.
NOTE: current chaining method should be refactored, for example, to run in parallel?
@asamuzaK
Revert "Return promise chain"
0c071fe 
This reverts commit c11588e.
@asamuzaK
Copy link
Contributor Author

asamuzaK commented Nov 13, 2020 •
edited

NOTE: UnhandledPromiseRejectionWarning are logged in build logs. Filed #20

https://dev.azure.com/criblio/js2bin/_build/results?buildId=1748&view=logs&j=0975ef43-79f0-500d-9f93-7109c7ec63a7&t=347eed54-f4d2-5fcd-ed9b-35e0cb99d283&l=6028

https://dev.azure.com/criblio/js2bin/_build/results?buildId=1748&view=logs&j=a0f6b896-e7cc-5558-0f61-d13b79b58942&t=c96fa010-0cd7-57d3-84f0-653414fb5cdb&l=8994

https://dev.azure.com/criblio/js2bin/_build/results?buildId=1748&view=logs&j=62f585f5-8e31-54d3-d47d-f390a4794291&t=f67703dd-44f0-5a91-ec83-30dc85bed5a5&l=7786

@asamuzaK
Copy link
Contributor Author

Ah, npm has a npm ci command.
Maybe npm run ci is a bit confusing.
I will add one more commit later which renames script to something like deploy.
Please wait until then.

@asamuzaK
Rename script
6ec8631
@asamuzaK
Update deps
5e08385
@asamuzaK
Update help message
8ea7344 
* indicate that the `--node` argument is optional
* format document style
  * capitalize first letter
  * add period
  * spacing
@asamuzaK
Copy link
Contributor Author

PR ready.

@asamuzaK
Copy link
Contributor Author

It doesn't seem to be reviewed, so I will withdraw the PR

@asamuzaK asamuzaK closed this Jan 17, 2021
@asamuzaK asamuzaK deleted the version branch January 17, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Resolve version information from online resources
1 participant
@asamuzaK