Skip to content

Commit

Permalink
build: use specific MDC version
Browse files Browse the repository at this point in the history
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing angular#22504 yesterday, because it ended up installing a version that was too old.

These changes lock us to a specific version.
  • Loading branch information
crisbeto authored and andrewseguin committed Jun 8, 2021
1 parent aeecb3c commit f9a371b
Show file tree
Hide file tree
Showing 3 changed files with 622 additions and 621 deletions.
96 changes: 48 additions & 48 deletions package.json
Expand Up @@ -63,7 +63,7 @@
"@types/googlemaps": "^3.43.1",
"@types/youtube": "^0.0.42",
"core-js-bundle": "^3.8.2",
"material-components-web": "^12.0.0-canary.00b5899dc.0",
"material-components-web": "12.0.0-canary.b87ebf74d.0",
"rxjs": "^6.5.3",
"rxjs-tslint-rules": "^4.33.1",
"systemjs": "0.19.43",
Expand Down Expand Up @@ -95,53 +95,53 @@
"@bazel/terser": "3.5.0",
"@bazel/typescript": "3.5.0",
"@firebase/app-types": "^0.6.1",
"@material/animation": "^12.0.0-canary.00b5899dc.0",
"@material/auto-init": "^12.0.0-canary.00b5899dc.0",
"@material/banner": "^12.0.0-canary.00b5899dc.0",
"@material/base": "^12.0.0-canary.00b5899dc.0",
"@material/button": "^12.0.0-canary.00b5899dc.0",
"@material/card": "^12.0.0-canary.00b5899dc.0",
"@material/checkbox": "^12.0.0-canary.00b5899dc.0",
"@material/chips": "^12.0.0-canary.00b5899dc.0",
"@material/circular-progress": "^12.0.0-canary.00b5899dc.0",
"@material/data-table": "^12.0.0-canary.00b5899dc.0",
"@material/density": "^12.0.0-canary.00b5899dc.0",
"@material/dialog": "^12.0.0-canary.00b5899dc.0",
"@material/dom": "^12.0.0-canary.00b5899dc.0",
"@material/drawer": "^12.0.0-canary.00b5899dc.0",
"@material/elevation": "^12.0.0-canary.00b5899dc.0",
"@material/fab": "^12.0.0-canary.00b5899dc.0",
"@material/feature-targeting": "^12.0.0-canary.00b5899dc.0",
"@material/floating-label": "^12.0.0-canary.00b5899dc.0",
"@material/form-field": "^12.0.0-canary.00b5899dc.0",
"@material/icon-button": "^12.0.0-canary.00b5899dc.0",
"@material/image-list": "^12.0.0-canary.00b5899dc.0",
"@material/layout-grid": "^12.0.0-canary.00b5899dc.0",
"@material/line-ripple": "^12.0.0-canary.00b5899dc.0",
"@material/linear-progress": "^12.0.0-canary.00b5899dc.0",
"@material/list": "^12.0.0-canary.00b5899dc.0",
"@material/menu": "^12.0.0-canary.00b5899dc.0",
"@material/menu-surface": "^12.0.0-canary.00b5899dc.0",
"@material/notched-outline": "^12.0.0-canary.00b5899dc.0",
"@material/radio": "^12.0.0-canary.00b5899dc.0",
"@material/ripple": "^12.0.0-canary.00b5899dc.0",
"@material/rtl": "^12.0.0-canary.00b5899dc.0",
"@material/segmented-button": "^12.0.0-canary.00b5899dc.0",
"@material/select": "^12.0.0-canary.00b5899dc.0",
"@material/shape": "^12.0.0-canary.00b5899dc.0",
"@material/slider": "^12.0.0-canary.00b5899dc.0",
"@material/snackbar": "^12.0.0-canary.00b5899dc.0",
"@material/switch": "^12.0.0-canary.00b5899dc.0",
"@material/tab": "^12.0.0-canary.00b5899dc.0",
"@material/tab-bar": "^12.0.0-canary.00b5899dc.0",
"@material/tab-indicator": "^12.0.0-canary.00b5899dc.0",
"@material/tab-scroller": "^12.0.0-canary.00b5899dc.0",
"@material/textfield": "^12.0.0-canary.00b5899dc.0",
"@material/theme": "^12.0.0-canary.00b5899dc.0",
"@material/tooltip": "^12.0.0-canary.00b5899dc.0",
"@material/top-app-bar": "^12.0.0-canary.00b5899dc.0",
"@material/touch-target": "^12.0.0-canary.00b5899dc.0",
"@material/typography": "^12.0.0-canary.00b5899dc.0",
"@material/animation": "12.0.0-canary.b87ebf74d.0",
"@material/auto-init": "12.0.0-canary.b87ebf74d.0",
"@material/banner": "12.0.0-canary.b87ebf74d.0",
"@material/base": "12.0.0-canary.b87ebf74d.0",
"@material/button": "12.0.0-canary.b87ebf74d.0",
"@material/card": "12.0.0-canary.b87ebf74d.0",
"@material/checkbox": "12.0.0-canary.b87ebf74d.0",
"@material/chips": "12.0.0-canary.b87ebf74d.0",
"@material/circular-progress": "12.0.0-canary.b87ebf74d.0",
"@material/data-table": "12.0.0-canary.b87ebf74d.0",
"@material/density": "12.0.0-canary.b87ebf74d.0",
"@material/dialog": "12.0.0-canary.b87ebf74d.0",
"@material/dom": "12.0.0-canary.b87ebf74d.0",
"@material/drawer": "12.0.0-canary.b87ebf74d.0",
"@material/elevation": "12.0.0-canary.b87ebf74d.0",
"@material/fab": "12.0.0-canary.b87ebf74d.0",
"@material/feature-targeting": "12.0.0-canary.b87ebf74d.0",
"@material/floating-label": "12.0.0-canary.b87ebf74d.0",
"@material/form-field": "12.0.0-canary.b87ebf74d.0",
"@material/icon-button": "12.0.0-canary.b87ebf74d.0",
"@material/image-list": "12.0.0-canary.b87ebf74d.0",
"@material/layout-grid": "12.0.0-canary.b87ebf74d.0",
"@material/line-ripple": "12.0.0-canary.b87ebf74d.0",
"@material/linear-progress": "12.0.0-canary.b87ebf74d.0",
"@material/list": "12.0.0-canary.b87ebf74d.0",
"@material/menu": "12.0.0-canary.b87ebf74d.0",
"@material/menu-surface": "12.0.0-canary.b87ebf74d.0",
"@material/notched-outline": "12.0.0-canary.b87ebf74d.0",
"@material/radio": "12.0.0-canary.b87ebf74d.0",
"@material/ripple": "12.0.0-canary.b87ebf74d.0",
"@material/rtl": "12.0.0-canary.b87ebf74d.0",
"@material/segmented-button": "12.0.0-canary.b87ebf74d.0",
"@material/select": "12.0.0-canary.b87ebf74d.0",
"@material/shape": "12.0.0-canary.b87ebf74d.0",
"@material/slider": "12.0.0-canary.b87ebf74d.0",
"@material/snackbar": "12.0.0-canary.b87ebf74d.0",
"@material/switch": "12.0.0-canary.b87ebf74d.0",
"@material/tab": "12.0.0-canary.b87ebf74d.0",
"@material/tab-bar": "12.0.0-canary.b87ebf74d.0",
"@material/tab-indicator": "12.0.0-canary.b87ebf74d.0",
"@material/tab-scroller": "12.0.0-canary.b87ebf74d.0",
"@material/textfield": "12.0.0-canary.b87ebf74d.0",
"@material/theme": "12.0.0-canary.b87ebf74d.0",
"@material/tooltip": "12.0.0-canary.b87ebf74d.0",
"@material/top-app-bar": "12.0.0-canary.b87ebf74d.0",
"@material/touch-target": "12.0.0-canary.b87ebf74d.0",
"@material/typography": "12.0.0-canary.b87ebf74d.0",
"@octokit/rest": "18.3.5",
"@rollup/plugin-babel": "^5.3.0",
"@rollup/plugin-commonjs": "^18.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages.bzl
Expand Up @@ -2,7 +2,7 @@
# all in-sync. This map is passed to each ng_package rule to stamp out the appropriate
# version for the placeholders.
ANGULAR_PACKAGE_VERSION = "^12.0.0 || ^13.0.0-0"
MDC_PACKAGE_VERSION = "^12.0.0-canary.00b5899dc.0"
MDC_PACKAGE_VERSION = "12.0.0-canary.b87ebf74d.0"
TSLIB_PACKAGE_VERSION = "^2.2.0"
RXJS_PACKAGE_VERSION = "^6.5.3"

Expand Down

0 comments on commit f9a371b

Please sign in to comment.