chore(main): release 5.0.0 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
release-please--branches--main--components--shaka-player
branch
from
3551333
to
bfa71c0
Compare
cristian-atehortua
pushed a commit
that referenced
this pull request
Apr 26, 2024
…QUENCE (shaka-project#6378) Fixes shaka-project#6377 When choosing to synchronize HLS streams using `EXT-X-MEDIA-SEQUENCE` instead of `EXT-X-PROGRAM-DATE-TIME` during LIVE playlist variant switches, Shaka unnecessarily drops 'old' segments and offsets the segment references of the new playlist so that the earliest reference represents media time `0`: https://github.com/shaka-project/shaka-player/blob/ea740ba2468f3b035d463ea9933aa7eeccf5c748/lib/hls/hls_parser.js#L610-L613 This is problematic, as the `StreamingEngine`'s media time used to download new segments is based off the latest segment references: https://github.com/shaka-project/shaka-player/blob/ea740ba2468f3b035d463ea9933aa7eeccf5c748/lib/media/streaming_engine.js#L1248-L1250 https://github.com/shaka-project/shaka-player/blob/ea740ba2468f3b035d463ea9933aa7eeccf5c748/lib/media/streaming_engine.js#L1385 For example: ``` Playlist download #1 EXT-X-MEDIA-SEQUENCE Media Time 0 0 1 6 2 12 3 18 Playlist download #2 (what happens now) EXT-X-MEDIA-SEQUENCE Media Time 6 0 7 6 8 12 9 18 Playlist download #2 (desired behavior) EXT-X-MEDIA-SEQUENCE Media Time 6 36 7 42 8 48 9 54 ``` Without this fix, and given the above example, if Shaka tries to request the segment at `time=36`, it will fail because the media state only has segment references up to `time=18`. Until the manifests, 'catch up', the player freezes; this can be especially problematic when a large amount of time accumulates before a variant switch occurs. This has been confirmed by Pluto TV to fix their freezing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
5.0.0 (2022-08-11)
⚠ BREAKING CHANGES
manifest.dash.defaultPresentationDelayhas been replaced bymanifest.defaultPresentationDelay(deprecated in v3.0.0)new(deprecated in v3.1.0)shaka.Player.prototype.addTextTrack()has been replaced byaddTextTrackAsync(), which returns aPromise(deprecated in v3.1.0)shaka.ui.TrackLabelFormathas been renamed toshaka.ui.Overlay.TrackLabelFormat(deprecated in v3.1.0)shaka.ui.FailReasonCodehas been renamed toshaka.ui.Overlay.FailReasonCode(deprecated in v3.1.0)shaka.offline.Storage.prototype.store()returnsAbortableOperationinstead ofPromise(deprecated in v3.0.0)shaka.offline.Storage.prototype.getStoreInProgress()has been removed; concurrent operations are supported, so callers don't need to check this (deprecated in v3.0.0)shaka.util.Uint8ArrayUtils.equalhas been replaced byshaka.util.BufferUtils.equal, which can handle multiple types of buffers (deprecated in v3.0.0)shaka.media.SegmentIndex.prototype.destroy()has been replaced byrelease(), which is synchronous (deprecated in v3.0.0)shaka.media.SegmentIterator.prototype.seek(), which mutates the iterator, has been replaced byshaka.media.SegmentIndex.getIteratorForTime()(deprecated in v3.1.0)shaka.media.SegmentIndex.prototype.merge()has become private; usemergeAndEvict()instead (deprecated in v3.2.0)AbrManagerplugins must implement theplaybackRateChanged()method (deprecated in v3.0.0)shaka.extern.Cue.prototype.spacerhas been replaced by the more clearly-namedlineBreak(deprecated in v3.1.0)IUIElementplugins must have arelease()method (notdestroy()) (deprecated in v3.0.0)Features
shaka.util.Uint8ArrayUtils.equalhas been replaced byshaka.util.BufferUtils.equal, which can handle multiple types of buffers (deprecated in v3.0.0) (ac5acc8)manifest.dash.defaultPresentationDelayhas been replaced bymanifest.defaultPresentationDelay(deprecated in v3.0.0) (ac5acc8)new(deprecated in v3.1.0) (ac5acc8)shaka.media.SegmentIndex.prototype.destroy()has been replaced byrelease(), which is synchronous (deprecated in v3.0.0) (ac5acc8)shaka.media.SegmentIndex.prototype.merge()has become private; usemergeAndEvict()instead (deprecated in v3.2.0) (ac5acc8)shaka.media.SegmentIterator.prototype.seek(), which mutates the iterator, has been replaced byshaka.media.SegmentIndex.getIteratorForTime()(deprecated in v3.1.0) (ac5acc8)shaka.offline.Storage.prototype.getStoreInProgress()has been removed; concurrent operations are supported, so callers don't need to check this (deprecated in v3.0.0) (ac5acc8)shaka.offline.Storage.prototype.store()returnsAbortableOperationinstead ofPromise(deprecated in v3.0.0) (ac5acc8)shaka.Player.prototype.addTextTrack()has been replaced byaddTextTrackAsync(), which returns aPromise(deprecated in v3.1.0) (ac5acc8)AbrManagerplugins must implement theplaybackRateChanged()method (deprecated in v3.0.0) (ac5acc8)IUIElementplugins must have arelease()method (notdestroy()) (deprecated in v3.0.0) (ac5acc8)shaka.extern.Cue.prototype.spacerhas been replaced by the more clearly-namedlineBreak(deprecated in v3.1.0) (ac5acc8)shaka.ui.FailReasonCodehas been renamed toshaka.ui.Overlay.FailReasonCode(deprecated in v3.1.0) (ac5acc8)shaka.ui.TrackLabelFormathas been renamed toshaka.ui.Overlay.TrackLabelFormat(deprecated in v3.1.0) (ac5acc8)Bug Fixes