-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolution/Mateus F Torres #1
Closed
mateus-f-torres
wants to merge
11
commits into
criticalmassbr:master
from
mateus-f-torres:resolution/mateus-f-torres
Closed
Resolution/Mateus F Torres #1
mateus-f-torres
wants to merge
11
commits into
criticalmassbr:master
from
mateus-f-torres:resolution/mateus-f-torres
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 351e5ae - Browse repository at this point
Copy the full SHA 351e5aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2146110 - Browse repository at this point
Copy the full SHA 2146110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13fb2d1 - Browse repository at this point
Copy the full SHA 13fb2d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fc6c99 - Browse repository at this point
Copy the full SHA 4fc6c99View commit details -
build: install and plug puppeteer and babel into project
Since we are using yarn v2 here we need to setup some things: 1. Some of the jest-puppeteer dependecies are not declared So we explicitly install and connect with .yarnrc.yml. 2. We need to add babel-jest and related dependencies So we can write tests with future Ecmascript features.
Configuration menu - View commit details
-
Copy full SHA for f9a058e - Browse repository at this point
Copy the full SHA f9a058eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f1a6fa - Browse repository at this point
Copy the full SHA 6f1a6faView commit details
Commits on Aug 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9b8ae95 - Browse repository at this point
Copy the full SHA 9b8ae95View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbfe9f0 - Browse repository at this point
Copy the full SHA fbfe9f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ada240 - Browse repository at this point
Copy the full SHA 8ada240View commit details -
Rename tests and description; Create constants for easy of modification; Start writing helpers for testing; Setup jest to run in band with -i flag
Configuration menu - View commit details
-
Copy full SHA for 0925869 - Browse repository at this point
Copy the full SHA 0925869View commit details -
refactor: create helpers.js file for visibility validation
Should investigate doing this with expect.extend({}); Would make the API closer to standard Jest behavior;
Configuration menu - View commit details
-
Copy full SHA for b57bedd - Browse repository at this point
Copy the full SHA b57beddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.