Bump Kubernetes dependencies (and CI workflow) to latest #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
commented
Jan 24, 2023
negz
changed the title
3 tasks
phisco
reviewed
Jan 25, 2023
phisco
approved these changes
Jan 25, 2023
hasheddan
approved these changes
Jan 25, 2023
This repo is a little out of date relative to our latest linting practices. Signed-off-by: Nic Cope <nicc@rk0n.org>
This required some updates to our implementations of client.Client, which now has a generic SubResource sub-client. Signed-off-by: Nic Cope <nicc@rk0n.org>
This also removes a few jobs that are no-ops on this repo, including e2e tests and artifact publishing. Probably better not to imply that we're doing these things when we aren't. Signed-off-by: Nic Cope <nicc@rk0n.org>
I thought this would help with compatibility, but unfortunately this package has breaking changes that will affect anyone who was using these types regardless. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
This linter has been deprecated and is disabled. I would have thought nolintlint would catch this, but it did not. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Closes #352
Closes #376
Fixes #373
This PR also updates the linter to bring it in line with c/c. I had to do this because my Go version was too new for the golangci-lint version this repo was using.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I built crossplane using the above PR, which uses this branch. I've applied platform-ref-gcp and created both example claims without issue: