Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release event an opt-in feature #778

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TimonPost
Copy link
Member

@TimonPost TimonPost commented Apr 8, 2023

  • Makes Event::Release and Event::Repeat an opt in rather then default enabled feature on windows and kitty. The motivation is that it isn't fully cross-platform and causes developers confusion when receiving two events unexpectedly.
  • Fixes the issue where people got an Enter release event at application start up.

Fixes: #752

@TimonPost TimonPost changed the title Timon/fix enter event Make release event an opt-in feature Apr 8, 2023
@TimonPost
Copy link
Member Author

@lesleyrs you can potentially keep the pull requests open. Guess it might be cleaner anyways to have this explicit check for press events even if not enabling the feature introduced in this pr.

@lesleyrs
Copy link
Contributor

lesleyrs commented Apr 8, 2023

@lesleyrs you can potentially keep the pull requests open. Guess it might be cleaner anyways to have this explicit check for press events even if not enabling the feature introduced in this pr.

Ok sounds good, I made it a mission to fix those libraries prior to this PR as the breakage was really quite bad for such a simple fix. But I'll try to get them merged still then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving release Enter command upon application start.
2 participants