Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Parse hex colour codes in serde::de::Deserialize #801

Merged
merged 2 commits into from Aug 5, 2023
Merged

Feature: Parse hex colour codes in serde::de::Deserialize #801

merged 2 commits into from Aug 5, 2023

Conversation

Piturnah
Copy link
Contributor

With this PR Crossterm will be able to deserialize Color from strings like "#d69bea".

@Piturnah Piturnah requested a review from TimonPost as a code owner July 28, 2023 16:09
@Piturnah Piturnah mentioned this pull request Jul 28, 2023
Closed
TimonPost
TimonPost approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@TimonPost TimonPost merged commit ff01914 into crossterm-rs:master Aug 5, 2023
6 checks passed
@Piturnah Piturnah deleted the feat/parse-hex branch August 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Piturnah @TimonPost