Add CSI 14 t sequence support
#810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
Done! |
|
I changed the timeout to be configurable so that it's more flexible, e.g. a session through ssh may need to wait for a bit large time. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #790 is merged, but some terminals (e.g. VSCode, Hyper canary which are
node-ptybased) do not implement theioctlsystem call to get the terminal's width and height -- always zeros are returned, but they can get the correct pixel size byCSI 14 t.I'm working on a terminal file manager where getting the correct width and height is critical for resizing images to be previewed, and I'll continue to add tests to the PR if it makes sense!