windows: improve/fix raw mode #815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atrox
force-pushed
the
bugfix/win-raw-mode
branch
from
85d00f0
to
1c7145d
Compare
Atrox
force-pushed
the
bugfix/win-raw-mode
branch
from
1c7145d
to
7d4aaa9
Compare
|
This is the first time I see an issue about this, and I used crossterm on windwos for years now with no issues I think its better if you open an issue first with what you encountered (+reproduction + os version) before attempting changes with no clear benefit and that in-itself isn't clear |
|
To reproduce my issue on windows: Enable raw mode with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw mode didn't quite work for me as I would have expected on windows. For example: function and arrow keys didn't work at all.
I took inspiration from the raw console mode set in the containerd/console library. After setting those verbatim, everything worked as expected on my side.
Please take those changes with a grain of salt, I'm not a windows guy.