Improve color detection across platforms #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
force-pushed
the
issue882
branch
2 times, most recently
from
7bbdbd9
to
b8ae856
Compare
|
Contains fix for #883 to unblock testing. Tested in Windows Terminal with bash (WSL) and pwsh.exe (WT uses conpty) and cmd.exe (which uses conhost). |
|
can you rebase now main is stable |
joshka
approved these changes
May 6, 2024
There was a problem hiding this comment.
LGTM
I'd suggest adding a small amount of details to the commit message body instead of just linking to the issue as this makes it easier for people to review what's changed in a release.
Something like:
`style::available_color_count()` now:
- checks support_ansi on windows
- uses COLORTERM environment variable with fallback to TERM
- supports 24bit / truecolor (reported as u16::MAX)
Would it be worthwhile to add unit tests for this? Perhaps using https://crates.io/crates/temp-env?
Fixes crossterm-rs#882 by improving `style::available_color_count()`: - Checks ANSI support on Windows. - Uses the COLORTERM environment variable and falls back to the TERM environment variable. - Supports "xterm-24bit" and "truecolor" values which return `u16::MAX`.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882 by improving
style::available_color_count():u16::MAX.