Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql request to 6.x #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ribeirojose
Copy link
Contributor

@ribeirojose ribeirojose commented Sep 28, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Updates graphql-request to ^6, and use the types published with the package.

  • What is the current behavior? (You can also link to an open issue here)

  • Use graphql-request ^4.

  • What is the new behavior (if this is a feature change)?

  • Use graphql-request ^6;

  • when importing the "ClientError" type, import from "graphql-request" directly.

  • Other information:

  • depends on update pkg version to match published in NPM (0.8.5) #227

@eitoball
Copy link
Collaborator

@ribeirojose Thank you for your PR. Can you rebase your branch?

@ribeirojose
Copy link
Contributor Author

done 👍 @eitoball

@eitoball
Copy link
Collaborator

@ribeirojose Thank you for rebasing. Can you fix the following failing spec?

    tests/swr.spec.ts:11:44 - error TS2307: Cannot find module '@graphql-codegen/typescript-graphql-request/visitor' or its corresponding type declarations.

    11 import { GraphQLRequestPluginConfig } from '@graphql-codegen/typescript-graphql-request/visitor'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants