Provide helmwave support #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please raise an issue to help understand the use case for this addition? Assuming we all agree it should go in like this then docs will need updating too. I appreciate it's your tool but helmwave looks quite young and we haven't heard anyone requesting it so I'm keen to learn more. |
|
I would want to have it as a variation. The main Dockerfile is for tools which are required to make lovely work and have builtin support in the code. We want to keep this slim for security. |
|
We can continue discussion in #489 issue if you prefer that way |
|
If you can explain how it would be useable in #489, we'd consider adding it as a variation. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (100.0%)
Files: 21
Issues: 0
gofmt: 100%
go_vet: 100%
gocyclo: 100%
golint: 100%
ineffassign: 100%
license: 100%
misspell: 100%
This report was generated using GoGitOps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks 馃憢
We have an awesome project for composing helm charts. And we would like to be part of argocd-lovely-plugin family.