Use paralellelRequests instead of connections to calculate req/sec in…

… benchmarks (nodejs#2800) * Use paralellelRequests instead of connections to calculate req/sec in benchmarks Signed-off-by: Matteo Collina <hello@matteocollina.com> * fixup Signed-off-by: Matteo Collina <hello@matteocollina.com> * Revert "fixup" This reverts commit afb3878. --------- Signed-off-by: Matteo Collina <hello@matteocollina.com>
crysmags · Feb 27, 2024 · 050975f · 050975f
1 parent 12e9080
commit 050975f
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 48 deletions.
diff --git a/README.md b/README.md
@@ -17,23 +17,31 @@ npm i undici
 
 ## Benchmarks
 
-The benchmark is a simple `hello world` [example](benchmarks/benchmark.js) using a
-50 TCP connections with a pipelining depth of 10 running on Node 20.10.0.
+The benchmark is a simple `hello world` [example](benchmarks/benchmark.js) using:
+
+* 50 TCP connections
+* A pipelining factor of 10 for undici
+* 200 parallel requests issued per iteration (sample)
+
+The benchmark was run on Linux on top of Node 20.10.0.
 
 ```
-│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
-|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
-│ got                 │      45 │ 1661.71 req/sec │  ± 2.93 % │                       - │
-│ node-fetch          │      20 │ 2164.81 req/sec │  ± 2.63 % │               + 30.28 % │
-│ undici - fetch      │      35 │ 2274.27 req/sec │  ± 2.70 % │               + 36.86 % │
-│ http - no keepalive │      15 │ 2376.04 req/sec │  ± 2.99 % │               + 42.99 % │
-│ axios               │      25 │ 2612.93 req/sec │  ± 2.89 % │               + 57.24 % │
-│ request             │      40 │ 2712.19 req/sec │  ± 2.92 % │               + 63.22 % │
-│ http - keepalive    │      45 │ 4393.25 req/sec │  ± 2.86 % │              + 164.38 % │
-│ undici - pipeline   │      45 │ 5484.69 req/sec │  ± 2.87 % │              + 230.06 % │
-│ undici - request    │      55 │ 7773.98 req/sec │  ± 2.93 % │              + 367.83 % │
-│ undici - stream     │      70 │ 8425.96 req/sec │  ± 2.91 % │              + 407.07 % │
-│ undici - dispatch   │      50 │ 9488.99 req/sec │  ± 2.85 % │              + 471.04 % │
+┌─────────┬───────────────────────┬─────────┬────────────────────┬────────────┬─────────────────────────┐
+│ (index) │         Tests         │ Samples │       Result       │ Tolerance  │ Difference with slowest │
+├─────────┼───────────────────────┼─────────┼────────────────────┼────────────┼─────────────────────────┤
+│    0    │         'got'         │   25    │ '3444.59 req/sec'  │ '± 2.88 %' │           '-'           │
+│    1    │     'node-fetch'      │   20    │ '4927.30 req/sec'  │ '± 2.46 %' │       '+ 43.04 %'       │
+│    2    │   'undici - fetch'    │   10    │ '5043.80 req/sec'  │ '± 1.87 %' │       '+ 46.43 %'       │
+│    3    │       'request'       │   35    │ '6389.13 req/sec'  │ '± 2.93 %' │       '+ 85.48 %'       │
+│    4    │        'axios'        │   25    │ '6920.61 req/sec'  │ '± 2.76 %' │      '+ 100.91 %'       │
+│    5    │ 'http - no keepalive' │   10    │ '9357.37 req/sec'  │ '± 2.24 %' │      '+ 171.65 %'       │
+│    6    │  'http - keepalive'   │   30    │ '9921.36 req/sec'  │ '± 2.83 %' │      '+ 188.03 %'       │
+│    7    │     'superagent'      │   10    │ '10118.35 req/sec' │ '± 2.18 %' │      '+ 193.75 %'       │
+│    8    │  'undici - pipeline'  │   10    │ '17106.69 req/sec' │ '± 1.46 %' │      '+ 396.62 %'       │
+│    9    │  'undici - request'   │   20    │ '21611.80 req/sec' │ '± 2.50 %' │      '+ 527.41 %'       │
+│   10    │   'undici - stream'   │   10    │ '24282.13 req/sec' │ '± 1.94 %' │      '+ 604.94 %'       │
+│   11    │  'undici - dispatch'  │   20    │ '24441.95 req/sec' │ '± 2.68 %' │      '+ 609.58 %'       │
+└─────────┴───────────────────────┴─────────┴────────────────────┴────────────┴─────────────────────────┘
 ```
 
 ## Quick Start

diff --git a/benchmarks/benchmark-http2.js b/benchmarks/benchmark-http2.js
@@ -1,7 +1,5 @@
 'use strict'
 
-const { connect } = require('node:http2')
-const { createSecureContext } = require('node:tls')
 const os = require('node:os')
 const path = require('node:path')
 const { readFileSync } = require('node:fs')
@@ -48,11 +46,6 @@ const httpsBaseOptions = {
   ...dest
 }
 
-const http2ClientOptions = {
-  secureContext: createSecureContext({ ca }),
-  servername
-}
-
 const undiciOptions = {
   path: '/',
   method: 'GET',
@@ -113,7 +106,9 @@ class SimpleRequest {
 }
 
 function makeParallelRequests (cb) {
-  return Promise.all(Array.from(Array(parallelRequests)).map(() => new Promise(cb)))
+  const res = Promise.all(Array.from(Array(parallelRequests)).map(() => new Promise(cb)))
+  res.catch(console.error)
+  return res
 }
 
 function printResults (results) {
@@ -143,10 +138,12 @@ function printResults (results) {
         last = mean
       }
 
+      console.log(mean)
+
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((1e9 * parallelRequests) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }
@@ -156,28 +153,6 @@ function printResults (results) {
 }
 
 const experiments = {
-  'http2 - request' () {
-    return makeParallelRequests(resolve => {
-      connect(dest.url, http2ClientOptions, (session) => {
-        const headers = {
-          ':path': '/',
-          ':method': 'GET',
-          ':scheme': 'https',
-          ':authority': `localhost:${dest.port}`
-        }
-
-        const request = session.request(headers)
-
-        request.pipe(
-          new Writable({
-            write (chunk, encoding, callback) {
-              callback()
-            }
-          })
-        ).on('finish', resolve)
-      })
-    })
-  },
   'undici - pipeline' () {
     return makeParallelRequests(resolve => {
       dispatcher

diff --git a/benchmarks/benchmark-https.js b/benchmarks/benchmark-https.js
@@ -160,7 +160,7 @@ function printResults (results) {
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((parallelRequests * 1e9) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }

diff --git a/benchmarks/benchmark.js b/benchmarks/benchmark.js
@@ -175,7 +175,7 @@ function printResults (results) {
       return {
         Tests: name,
         Samples: size,
-        Result: `${((connections * 1e9) / mean).toFixed(2)} req/sec`,
+        Result: `${((parallelRequests * 1e9) / mean).toFixed(2)} req/sec`,
         Tolerance: `± ${((standardError / mean) * 100).toFixed(2)} %`,
         'Difference with slowest': relative > 0 ? `+ ${relative.toFixed(2)} %` : '-'
       }

diff --git a/benchmarks/server.js b/benchmarks/server.js
@@ -24,10 +24,15 @@ if (cluster.isPrimary) {
   }
 } else {
   const buf = Buffer.alloc(64 * 1024, '_')
+  let i = 0
   const server = createServer((req, res) => {
+    i++
     setTimeout(function () {
       res.end(buf)
     }, timeout)
   }).listen(port)
   server.keepAliveTimeout = 600e3
+  setInterval(() => {
+    console.log(`Worker ${process.pid} processed ${i} requests`)
+  }, 5000)
 }