fix(fetch): makeNetworkError called twice when httpNetworkFetch run e…

…rror (nodejs#1353)
crysmags · Feb 27, 2024 · 16a0ebc · 16a0ebc
1 parent 22d28eb
commit 16a0ebc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/fetch/index.js b/lib/fetch/index.js
@@ -2029,7 +2029,7 @@ async function httpNetworkFetch (
 
           fetchParams.controller.terminate(error)
 
-          reject(makeNetworkError(error))
+          reject(error)
         }
       }
     ))

diff --git a/test/fetch/client-fetch.js b/test/fetch/client-fetch.js
@@ -332,3 +332,13 @@ test('post FormData with File', (t) => {
     t.ok(/filename123/.test(result))
   })
 })
+
+test('invalid url', async (t) => {
+  t.plan(1)
+
+  try {
+    await fetch('http://invalid')
+  } catch (e) {
+    t.match(e.cause.message, 'invalid')
+  }
+})